Uploaded image for project: 'RichFaces'
  1. RichFaces
  2. RF-10775

ignoreDupResponce: implemented wrong according to code review

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Critical
    • Resolution: Done
    • Affects Version/s: 4.0.0.CR1
    • Fix Version/s: 4.0.0.Final
    • Component/s: core
    • Labels:
      None

      Description

      In order to ignore dom updates two conditions should be met:
      1) next request to be sent should be "similar" to the current from which the responce came
      2) current should have ignoreDupRespoce = true.

      but according to current code 1) step checked in a wrong way. The last event is get instead of the next.

      Code:
      isIgnoreResponse: function ()

      { var lastEntry = getLastEntry(); return lastEntry && lastRequestedEntry.isIgnoreDupResponses() && lastRequestedEntry.getRequestGroupId() == lastEntry.getRequestGroupId(); }

      ,
      var getLastEntry = function ()

      { var lastIdx = items.length - 1; return items[lastIdx]; }

      ;

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                Konstantin.Mishin Konstantin Mishin
                Reporter:
                ilya_shaikovsky Ilya Shaikovsky
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: