Details
-
Task
-
Resolution: Done
-
Critical
-
None
-
None
-
2020 Week 28-30 (from Jul 6)
-
3
-
NEW
-
NEW
Description
In the root pom.xml, both on master and 7.x, change this line back to true:
<spotbugs.failOnViolation>true</spotbugs.failOnViolation>
Then run a *-Dfull * build.
You'll get these errors to fix, related to the ScoreDirector.setWorkingSolution() null checks:
[ERROR] Nullcheck of scoreDirector at line 51 of value previously dereferenced in org.optaplanner.core.impl.score.DefaultScoreManager.explainScore(Object) [org.optaplanner.core.impl.score.DefaultScoreManager, org.optaplanner.core.impl.score.DefaultScoreManager] At DefaultScoreManager.java:[line 51]Redundant null check at DefaultScoreManager.java:[line 53] RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE [ERROR] Nullcheck of scoreDirector at line 43 of value previously dereferenced in org.optaplanner.core.impl.score.DefaultScoreManager.updateScore(Object) [org.optaplanner.core.impl.score.DefaultScoreManager, org.optaplanner.core.impl.score.DefaultScoreManager] At DefaultScoreManager.java:[line 43]Redundant null check at DefaultScoreManager.java:[line 45] RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE [ERROR] Nullcheck of uncorruptedScoreDirector at line 659 of value previously dereferenced in org.optaplanner.core.impl.score.director.AbstractScoreDirector.assertScoreFromScratch(Score, Object, boolean) [org.optaplanner.core.impl.score.director.AbstractScoreDirector, org.optaplanner.core.impl.score.director.AbstractScoreDirector] At AbstractScoreDirector.java:[line 659]Redundant null check at AbstractScoreDirector.java:[line 672] RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE [ERROR] Nullcheck of uncorruptedScoreDirector at line 98 of value previously dereferenced in org.optaplanner.core.impl.score.director.AbstractScoreDirectorFactory.assertScoreFromScratch(Object) [org.optaplanner.core.impl.score.director.AbstractScoreDirectorFactory, org.optaplanner.core.impl.score.director.AbstractScoreDirectorFactory] At AbstractScoreDirectorFactory.java:[line 98]Redundant null check at AbstractScoreDirectorFactory.java:[line 106] RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE [ERROR] Nullcheck of scoreDirector at line 121 of value previously dereferenced in org.optaplanner.core.impl.solver.DefaultSolver.explainBestScore() [org.optaplanner.core.impl.solver.DefaultSolver, org.optaplanner.core.impl.solver.DefaultSolver] At DefaultSolver.java:[line 121]Redundant null check at DefaultSolver.java:[line 123] RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE
