Uploaded image for project: 'OpenShift Java Client'
  1. OpenShift Java Client
  2. OSJC-12 support protocol version 1.2 in openshift-java-client
  3. OSJC-13

handle IApplication#getEmbeddedCartridges correctly with changes to protocol 1.2

    XMLWordPrintable

Details

    • Sub-task
    • Resolution: Done
    • Major
    • None
    • None
    • None
    • None

    Description

      In 1.1 the cartridges that you get reported when listing them on a application changed (IApplication#getEmbeddedCartridges):

      • 1.0:
        would report the embedded cartridges only
      • 1.1:
        would report the embedded cartridges and the application type (cartridge)

      see here: https://github.com/openshift/crankcase/pull/224
      The error that this caused was discussed here:
      https://bugzilla.redhat.com/show_bug.cgi?id=838611

      OpenShift pushed the discussed change (application-type reported as embedded cartridge) to protocol v1.1 and fixed the issue on the server-side. Our client, that currently requests protocol v1.0 has no issue since the fix. We have to make sure we support protocol 1.1 and are able to handle this correctly.

      Attachments

        Issue Links

          is blocked by

          Feature Request - Feature requests from customers and/or users OSJC-12 support protocol version 1.2 in openshift-java-client

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Enhancement - An enhancement to or refactoring of existing functionality that is not configurable by an end user (typically a change made by an internal team that affects users) OSJC-28 openshift-java-client: should have integration test that asserts that app type is not reported in embedded cartridges

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed
          relates to

          Bug - A problem that impairs or prevents the functions of the product. JBIDE-13561 Cannot embed cartridges

          • Blocker - To be worked above all other priorities. This term is chosen when the severity of the issue is very high, has no workaround, or the effort for the change is comparatively low. Issues that may be very publicly visible and could generate significant media attention may also drive a higher priority.
          • Closed

          Task - Represents a small unit of work that is not end-user facing. JBIDE-13559 Cannot embed cartridges (WATCHER ISSUE)

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Activity

            People

              adietish@redhat.com André Dietisheim
              adietish@redhat.com André Dietisheim
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: