Details
-
Bug
-
Resolution: Done
-
Minor
-
None
-
False
-
False
-
0
-
Undefined
-
Not Supported
-
ODC Sprint 206
-
Medium
Description
Description of problem:
When the user imports from Git and selects "Serverless Deployment" as resource type, the generated BuildConfig is incomplete and shows a warning alert when on the BuildConfig detail page.
The warning blames a missing Secret "${service-name}-github-webhook-secret"
Everything else (build and service start) works fine.
Prerequisites (if any, like setup, operators/versions):
- OpenShift Serverless operator
Steps to Reproduce
- Open developer perspective, Add page, Import from Git
- Enter a git URL
- As resources select "Serverless Deployment"
- Create
- Open navigation entry "Builds" and the new created "BuildConfig" (app name)
Actual results:
The BuildConfig detail page shows a warning between the general infos and webhooks.
There is 1 warning alert.
Error: secrets "nodeinfo-serverless-github-webhook-secret" not found
The BuildConfig links two webhooks. The generic webhook is clickable, the GitHub webhook is not clickable.
The YAML tab lists two secrets for triggers. Only one of the both secrets is created.
triggers: - type: Generic generic: secretReference: name: nodeinfo-serverless-generic-webhook-secret # exists - type: GitHub github: secretReference: name: nodeinfo-serverless-github-webhook-secret # does not exist - type: ImageChange imageChange: lastTriggeredImageID: >- image-registry.openshift-image-registry.svc:5000/....
Expected results:
The BuildConfig should now show a warning that a secret is missing.
Both secrets should be created OR the second trigger should not be created.
Reproducibility (Always/Intermittent/Only Once):
Always
Build Details:
4.9 master (tested with console commit c0ba821c0b385db10107f4413d67abe01f89f0c3)
Additional info:
None