Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-4279

Custom Victory-Core components in monitoring ui code causing build issues

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • None
    • 4.13.0
    • Monitoring
    • -
    • Moderate
    • Rejected
    • False
    • Hide

      None

      Show
      None

      Description of problem:

      Custom Victory-Core components in monitoring ui code causing build issues when updating pf to release 2022.13. PatternFly updated their victory version in this pf release and it is causing an api mismatch with the custom monitoring code. The following is the output of the build:
      
      ERROR in /Users/jcaiani/src/github.com/openshift/console-pf-updates/console/frontend/public/components/graphs/tooltip.tsx
      ERROR in /Users/jcaiani/src/github.com/openshift/console-pf-updates/console/frontend/public/components/graphs/tooltip.tsx(49,50):
      TS2554: Expected 2 arguments, but got 1.
      
      
      ERROR in /Users/jcaiani/src/github.com/openshift/console-pf-updates/console/frontend/public/components/graphs/tooltip.tsx
      ERROR in /Users/jcaiani/src/github.com/openshift/console-pf-updates/console/frontend/public/components/graphs/tooltip.tsx(79,34):
      TS2554: Expected 2 arguments, but got 1.
      
      
      ERROR in /Users/jcaiani/src/github.com/openshift/console-pf-updates/console/frontend/public/components/graphs/tooltip.tsx
      ERROR in /Users/jcaiani/src/github.com/openshift/console-pf-updates/console/frontend/public/components/graphs/tooltip.tsx(94,35):
      TS2554: Expected 2 arguments, but got 1.
      
      
      ERROR in /Users/jcaiani/src/github.com/openshift/console-pf-updates/console/frontend/public/components/graphs/tooltip.tsx
      ERROR in /Users/jcaiani/src/github.com/openshift/console-pf-updates/console/frontend/public/components/graphs/tooltip.tsx(134,42):
      TS2554: Expected 2 arguments, but got 1.
      
      
      ERROR in /Users/jcaiani/src/github.com/openshift/console-pf-updates/console/frontend/public/components/graphs/tooltip.tsx
      ERROR in /Users/jcaiani/src/github.com/openshift/console-pf-updates/console/frontend/public/components/graphs/tooltip.tsx(135,42):
      TS2554: Expected 2 arguments, but got 1.
      
      
      ERROR in /Users/jcaiani/src/github.com/openshift/console-pf-updates/console/frontend/public/components/graphs/tooltip.tsx
      ERROR in /Users/jcaiani/src/github.com/openshift/console-pf-updates/console/frontend/public/components/graphs/tooltip.tsx(162,43):
      TS2554: Expected 2 arguments, but got 1.
      
      
      ERROR in /Users/jcaiani/src/github.com/openshift/console-pf-updates/console/frontend/public/components/graphs/tooltip.tsx
      ERROR in /Users/jcaiani/src/github.com/openshift/console-pf-updates/console/frontend/public/components/graphs/tooltip.tsx(163,43):
      TS2554: Expected 2 arguments, but got 1.
      
      
      ERROR in /Users/jcaiani/src/github.com/openshift/console-pf-updates/console/frontend/public/components/graphs/tooltip.tsx
      ERROR in /Users/jcaiani/src/github.com/openshift/console-pf-updates/console/frontend/public/components/graphs/tooltip.tsx(250,50):
      TS2554: Expected 2 arguments, but got 1.
      
      
      ERROR in /Users/jcaiani/src/github.com/openshift/console-pf-updates/console/frontend/public/components/monitoring/query-browser.tsx
      ERROR in /Users/jcaiani/src/github.com/openshift/console-pf-updates/console/frontend/public/components/monitoring/query-browser.tsx(267,7):
      TS2605: JSX element type 'VictoryPortal' is not a constructor function for JSX elements.
        Type 'VictoryPortal' is missing the following properties from type 'ElementClass': setState, forceUpdate, props, state, refs
      Child html-webpack-plugin for "index.html":

      Version-Release number of selected component (if applicable):

       

      How reproducible:

       

      Steps to Reproduce:

      1.
      2.
      3.
      

      Actual results:

       

      Expected results:

       

      Additional info:

       

            gbernal@redhat.com Gabriel Bernal
            jcaiani@redhat.com Joseph Caiani
            Junqi Zhao Junqi Zhao
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved: