Uploaded image for project: 'OpenShift Bugs'
  1. OpenShift Bugs
  2. OCPBUGS-23782

LVM Controller not respecting Tolerations while counting VGs created

XMLWordPrintable

    • Low
    • No
    • 2
    • OCPEDGE Sprint 245, OCPEDGE Sprint 246
    • 2
    • False
    • Hide

      None

      Show
      None
    • N/A
    • Release Note Not Required

      Description of problem:

      LVMCluster CR '.status.state' stuck in 'Progressing' even when all VGs are created and running fine

      Version-Release number of selected component (if applicable):

      4.14

      How reproducible:

      Always

      Steps to Reproduce:

      - Deployed LVMS 4.14
spec:
  storage:
    deviceClasses:
      - deviceSelector:
          paths:
            - '/dev/disk/by-path/pci-0000:61:00.0-nvme-1'
        fstype: xfs
        name: hcp-etcd
        nodeSelector:
          nodeSelectorTerms:
            - matchExpressions:
                - key: node-role.kubernetes.io/master
                  operator: Exists
        thinPoolConfig:
          name: thin-pool-1
          overprovisionRatio: 10
          sizePercent: 90
  tolerations:
    - effect: NoSchedule
      key: node-role.kubernetes.io/master
status:
  deviceClassStatuses:
    - name: hcp-etcd
      nodeStatus:
        - devices:
            - /dev/nvme0n1
          node: control-1-ru2xxxx
          status: Ready
        - devices:
            - /dev/nvme0n1
          node: control-1-ru3xxxx
          status: Ready
        - devices:
            - /dev/nvme0n1
          node: control-1-ru4xxxx
          status: Ready
  state: Progressing
- When above is deployed, we are explicitly asking for VGs to be created on control nodes however for updating the state, counting of VGs on control nodes is being skipped, in here https://github.com/openshift/lvm-operator/blob/release-4.14/controllers/lvmcluster_controller.go#L315C1-L315C54

      Actual results:

      state is in 'Progressing'

      Expected results:

      state should be 'Ready'

      Additional info:

      observable behavior for this bug is state not going into Ready, may have different side effects as well, wasn't able to check fully

            [OCPBUGS-23782] LVM Controller not respecting Tolerations while counting VGs created

            Chad Scribner made changes -
            Labels Original: triaged New: ocpedge triaged
            Errata Tool made changes -
            Resolution New: Done-Errata [ 10803 ]
            Status Original: Verified [ 10015 ] New: Closed [ 6 ]

            Errata Tool added a comment -

            Since the problem described in this issue should be resolved in a recent advisory, it has been closed.

            For information on the advisory (LVMS 4.14.z Bug Fix Update), and where to find the updated files, follow the link below.

            If the solution does not work for you, open a new bug report.
            https://access.redhat.com/errata/RHBA-2024:0633

            Errata Tool added a comment - Since the problem described in this issue should be resolved in a recent advisory, it has been closed. For information on the advisory (LVMS 4.14.z Bug Fix Update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2024:0633
            Errata Tool made changes -
            Remote Link New: This issue links to "RHBA-2024:126820 (Web Link)" [ 1535460 ]
            Chad Scribner made changes -
            Severity New: Low [ 26753 ]
            Rahul Deore made changes -
            Status Original: ON_QA [ 15723 ] New: Verified [ 10015 ]
            OpenShift Jira Bot made changes -
            Release Note Text New: N/A
            Suleyman Akbas made changes -
            Release Note Type New: No Doc Update [ 31862 ]

            OpenShift Jira Bot added a comment -

            Hi sakbas@redhat.com,

            Bugs should not be moved to Verified without first providing a Release Note Type("Bug Fix" or "No Doc Update") and for type "Bug Fix" the Release Note Text must also be provided. Please populate the necessary fields before moving the Bug to Verified.

            OpenShift Jira Bot added a comment - Hi sakbas@redhat.com , Bugs should not be moved to Verified without first providing a Release Note Type("Bug Fix" or "No Doc Update") and for type "Bug Fix" the Release Note Text must also be provided. Please populate the necessary fields before moving the Bug to Verified.
            Suleyman Akbas made changes -
            Status Original: MODIFIED [ 14454 ] New: ON_QA [ 15723 ]
            Suleyman Akbas made changes -
            Target Version Original: 4.15.0 [ 12407353 ] New: 4.14.z [ 12402535 ]
            Chad Scribner made changes -
            Sprint Original: OCPEDGE Sprint 245 [ 55798 ] New: OCPEDGE Sprint 245, OCPEDGE Sprint 246 [ 55798, 55799 ]
            GitLab CEE Bot made changes -
            Remote Link New: This issue links to "Merge request - Updated US source to: a9b09ff Merge pull request #514 from suleymanakbas91/tolerations-fix (Web Link)" [ 1491190 ]

            GitLab CEE Bot added a comment -

            CPaaS Service Account mentioned this issue in a merge request of ceph / lvms on branch lvms-4.14-rhel-9_upstream_ea9df66e02dca0850a0910f4b6e0b381:

            Updated US source to: a9b09ff Merge pull request #514 from suleymanakbas91/tolerations-fix

            GitLab CEE Bot added a comment - CPaaS Service Account mentioned this issue in a merge request of ceph / lvms on branch lvms-4.14-rhel-9_ upstream _ea9df66e02dca0850a0910f4b6e0b381 : Updated US source to: a9b09ff Merge pull request #514 from suleymanakbas91/tolerations-fix
            OpenShift Prow Bot made changes -
            Status Original: POST [ 15726 ] New: MODIFIED [ 14454 ]
            Suleyman Akbas made changes -
            Target Version Original: 4.14.0 [ 12402534 ] New: 4.14 [ 12402533 ]
            Suleyman Akbas made changes -
            Status Original: New [ 10016 ] New: POST [ 15726 ]
            OpenShift Prow Bot made changes -
            Remote Link New: This issue links to "openshift/lvm-operator#514: [release-4.14] OCPBUGS-23782: Take tolerations into consideration for readiness check (Web Link)" [ 1484044 ]
            Suleyman Akbas made changes -
            Sprint New: OCPEDGE Sprint 245 [ 55798 ]
            Suleyman Akbas made changes -
            Target Version Original: 4.15.0 [ 12407353 ] New: 4.14.0 [ 12402534 ]
            Suleyman Akbas made changes -
            Link New: This issue clones OCPBUGS-23191 [ OCPBUGS-23191 ]
            Suleyman Akbas created issue -

              sakbas@redhat.com Suleyman Akbas
              rhn-support-lgangava Leela Gangavarapu
              Rahul Deore Rahul Deore
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                Resolved: