Uploaded image for project: 'mod_cluster'
  1. mod_cluster
  2. MODCLUSTER-621

maxbufsize doesn't include JVMROUTESZ

    XMLWordPrintable

Details

    Description

      https://github.com/modcluster/mod_proxy_cluster/blob/master/native/mod_manager/mod_manager.c#L2956-L2959

          if (mconf->maxmesssize)
             maxbufsiz = mconf->maxmesssize;
          else {
             /* we calculate it */
             maxbufsiz = 9 + JVMROUTESZ;
             maxbufsiz = bufsiz + (mconf->maxhost * HOSTALIASZ) + 7;
             maxbufsiz = bufsiz + (mconf->maxcontext * CONTEXTSZ) + 8;
          }
          if (maxbufsiz< MAXMESSSIZE)
             maxbufsiz = MAXMESSSIZE;
          buff = apr_pcalloc(r->pool, maxbufsiz);
      

      It looks like maxbufsize will never include the 9+JVMROUTESZ since it overwritten with new value in following line. Is this a problem?

      Attachments

        Activity

          People

            rhn-engineering-jclere Jean-Frederic Clere
            rhn-support-rbost Robert Bost
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: