Details

    • Type: Enhancement
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: 9.0.3
    • Fix Version/s: 11.0.0
    • Component/s: Protocol - SAML
    • Labels:
      None
    • Docs QE Status:
      NEW
    • QE Status:
      NEW

      Description

      I was investigating the modifications required to add the AttributeConsumingService section to the SAML client component metadata and I noticed that both SAML IdP and SP descriptors are currently generated by string concatenations/property replacement:

      https://github.com/keycloak/keycloak/blob/cbab159aa87ca5e3443b3e87fdbf8de40542d1d3/saml-core/src/main/java/org/keycloak/saml/SPMetadataDescriptor.java#L26-L49

      https://github.com/keycloak/keycloak/blob/cbab159aa87ca5e3443b3e87fdbf8de40542d1d3/services/src/main/java/org/keycloak/protocol/saml/SamlService.java#L631-L654

      This makes much harder to properly expose the additional properties available in the SAML standard and is prone to errors and inconsistencies. I think it would be a good idea to refactor those methods to use the already-existing SAMLMetadataWriter class.

      I will provide a pull request that replicates the current document generation using the XML types.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                l.scorcia Luca Leonardo Scorcia
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: