Uploaded image for project: 'JGroups'
  1. JGroups
  2. JGRP-662

max_bundle_size checks should only happen when bundling is enabled (either via conf file or JMX)

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Minor Minor
    • 2.7
    • 2.4.1 SP4
    • None
    • Low

      If enable_bundling is disabled (false), why does JGroups read max_bundle_size and
      max_bundle_timeout values? These max values are used within TP.Blunder but this is
      not created if bundling is disabled. JGroups should only read and make the necessary
      processing for max_bundle_size and max_bundle_timeout if bundling is enabled. I'll
      fill in a JIRA for this.

      Seems like bundling could be enabled via dynamically via JMX (TPMBean). Maybe at
      this point JGroups should read the values from the configuration file.

      Alternatively, values could have already been read even if bundling was disabled, but
      calls like this in TP.setProperties:

      if(bundle_size > max_bundle_size)

      { if(log.isErrorEnabled()) log.error("max_bundle_size (" + bundle_size + ") is greater than largest TP fragmentation size (" + max_bundle_size + ')'); return false; }

      Should only happen if bundling was enabled either statically or dynamically via the MBean,
      specially since max_bundle_size value comes from a attempt to guess the maximum size of
      a Datagram packet by sending one, which is dynamic value that could change over time.

              rhn-engineering-bban Bela Ban
              rh-ee-galder Galder ZamarreƱo
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Created:
                Updated:
                Resolved: