Uploaded image for project: 'JGroups'
  1. JGroups
  2. JGRP-2042

Improve performance of Message#writeHeader

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Done
    • Minor
    • 4.0
    • None
    • None

    Description

      The following stacktrace, taken with JFR, is highlighting a CPU consumer which could be optimised.

      Stack Trace	Sample Count	Percentage(%)
java.util.IdentityHashMap.get(Object)	66	2.224
   org.jgroups.conf.ClassConfigurator.getMagicNumber(Class)	66	2.224
      org.jgroups.Message.writeHeader(Header, DataOutput)	66	2.224

      One idea could be to use an ad-hoc implementation of Map which takes advantage of the key being a Class. An interesting alternative would be to avoid the map lookup altogether, by having the Header expose a method like "writeMagicNumber(DataInput to)".

      Attachments

        Issue Links

          is related to

          Enhancement - An enhancement to or refactoring of existing functionality that is not configurable by an end user (typically a change made by an internal team that affects users) JGRP-1982 RequestCorrelator: use IntHashMap / LongHashmap for request correlation

          • Minor - To be worked after urgent, high, and medium priorities are resolved. This term is chosen when the severity of the issue is low, or the complexity or effort to correct it may be higher, relatively speaking. For low priority issues, known workarounds exist or are not needed due to the trivial effort needed to address the issue.
          • Resolved

          Activity

            People

              rhn-engineering-bban Bela Ban
              sgrinove Sanne Grinovero
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: