Uploaded image for project: 'JBoss Transaction Manager'
  1. JBoss Transaction Manager
  2. JBTM-3132

Common parent maven module for Narayana quickstarts

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Done
    • Icon: Major Major
    • 5.10.5.Final
    • 5.9.5.Final
    • Testing
    • None

      It would be beneficial to create a common quickstart maven module.

      My intention is to have a one place where we can define:

      • common profiles could be defined (one of such profile is Arquillian JDK9+ which defines JVM arguments needed for smooth run of tests, see https://issues.jboss.org/projects/JBTM/issues/JBTM-3122)
      • common properties like arquillian version. This has benefit that quickstarts will run faster on CI as there won't be multiple versions to be downloaded.
      • common repositories like jboss one
      • unified checkstyle definition for all the quickstarts would be coded in one way which makes them easier to read

      The quickstarts were designed to be independent on each other. The task is not to unified them. The proposal is about creating a place where a common stuff can be placed to. Otherwise the same configuration needs to be copied to multiple places. Which is hard to maintain

      Other projects, e.g. WildFly, use the same approach of common parent, see https://github.com/wildfly/quickstart/blob/master/app-client/pom.xml

            [JBTM-3132] Common parent maven module for Narayana quickstarts

            Mayank Kunwar (Inactive) added a comment -

            The intention of pull/283 is to support JBTM-3122, so, the changes required for quickstart tests to run on JDK9+ versions are done as part of this pull request.
            So every module that are required to run their tests over JDK9+ versions, only for them, I have included the parent in their pom.xml file, so that they could use same properties defined in parent pom.xml, when ran on JDK9+ versions.

            Some of the modules in quickstart were not compiling when I tried adding parent to their pom.xml file, due to some incompatibility/conflicts specific to particular module with parent.

            Mayank Kunwar (Inactive) added a comment - The intention of pull/283 is to support JBTM-3122 , so, the changes required for quickstart tests to run on JDK9+ versions are done as part of this pull request. So every module that are required to run their tests over JDK9+ versions, only for them, I have included the parent in their pom.xml file, so that they could use same properties defined in parent pom.xml, when ran on JDK9+ versions. Some of the modules in quickstart were not compiling when I tried adding parent to their pom.xml file, due to some incompatibility/conflicts specific to particular module with parent.

              mkunwar1 Mayank Kunwar (Inactive)
              ochaloup@redhat.com Ondrej Chaloupka (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: