Uploaded image for project: 'JBRULES'
  1. JBRULES
  2. JBRULES-2913

SingleSessionCommandService Constructor Eats an Actual / Real Exception on Rollback

    Details

    • Workaround:
      Workaround Exists
    • Workaround Description:
      Hide

      Debug and see the stacktrace of t1

      Show
      Debug and see the stacktrace of t1
    • Estimated Difficulty:
      Low

      Description

      Scenario: The constructor of SingleSessionCommandService tries to persist the created SessionInfo and fails.
      Problem: Because of the failure, SingleSessionCommandService tries to rollback the TX. If the rollback also fail, an exception is thrown with the cause, but the original problem (The failure on SessionInfo persistence) is swallowed.
      The code of the catch section demonstrate this:

      try

      { this.txm.begin(); //this.appScopedEntityManager.joinTransaction(); registerRollbackSync(); jpm.getApplicationScopedPersistenceContext().persist( this.sessionInfo ); this.txm.commit(); }

      catch ( Exception t1 ) {
      try

      { this.txm.rollback(); }

      catch ( Throwable t2 )

      { throw new RuntimeException( "Could not commit session or rollback", t2 ); }

      throw new RuntimeException( "Could not commit session",
      t1 );
      }

      If this.txm.rollback() fails, t1 is never logged.

      A similar issue was fixed in JBRULES-2656

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  eaa Esteban Aliverti
                  Reporter:
                  eaa Esteban Aliverti
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: