Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: EAP 6.0.0 ER 7, EAP 6.0.0
    • Fix Version/s: EAP 6.0.1 ER 1
    • Component/s: None
    • Labels:
      None
    • Affects:
      Release Notes

      Description

      According to https://community.jboss.org/wiki/LoggingIds every subsystem has its own range for message Id's. But some subsystems violate their range and create messages with Id's allocated to other subsystems, thus creating messages with duplicate Id's.

      Id: 11100
      Subsystem Id Range:
      EE = 11000 - 11099
      Embedded = 11100 - 11199

      Correct:

      jboss-eap-6.0-src/embedded/src/main/java/org/jboss/as/embedded/EmbeddedLogger.java
      @LogMessage(level = WARN)
      @Message(id = 11100, value = "Could not close handle to mounted %s")
      void cannotCloseFile(@Cause Throwable cause, VirtualFile file);

      Message with same Id also in:

      jboss-eap-6.0-src/ee/src/main/java/org/jboss/as/ee/EeMessages.java
      @Message(id = 11100, value = "Failed to load jboss.properties")
      DeploymentUnitProcessingException failedToLoadJbossProperties(@Cause IOException e);


      Id: 12100 - 12113
      Subsystem Id Range:
      Process Controller = 12000 - 12099
      Protocol = 12100 - 12199

      Correct:

      jboss-eap-6.0-src/protocol/src/main/java/org/jboss/as/protocol/ProtocolLogger.java
      @LogMessage(level = WARN)
      @Message(id = 12100, value = "Got error closing channel %s")
      void errorClosingChannel(String message);

      Message with same Id also in:

      jboss-eap-6.0-src/process-controller/src/main/java/org/jboss/as/process/protocol/ProtocolLogger.java
      @LogMessage(level = WARN)
      @Message(id = 12100, value = "Got error closing channel %s")
      void errorClosingChannel(String message);

      so on for all (14) messages in process-controller's ProtocolLogger. All messages should have different Id.


      Id: 13300 - 13305
      Subsystem Id Range:
      Security = 13100 - 13199
      JDR = 13300 - 13399

      Correct:

      jboss-eap-6.0-src/jdr/jboss-as-jdr/src/main/java/org/jboss/as/jdr/JdrLogger.java
      @LogMessage(level = INFO)
      @Message(id=13300, value="Starting creation of a JBoss Diagnostic Report (JDR).")
      void startingCollection();

      Message with same Id also in:

      jboss-eap-6.0-src/security/src/main/java/org/jboss/as/security/SecurityMessages.java
      @Message(id = 13300, value = "Unable to get the Module Class Loader")
      IllegalStateException unableToGetModuleClassLoader(@Cause Throwable e);

      same for 13301 - 13305 in SecurityMessages. Messages should have different Id.


      Id: 15848 - 15849
      Subsystem Id Range:
      Host Controller (host packages) = 10900 - 10999
      Server = 15700 - 15999, 18700 - 18799

      Correct:

      jboss-eap-6.0-src/server/src/main/java/org/jboss/as/server/ServerMessages.java
      @Message(id = 15848, value = "Determined modules directory does not exist: %s")
      IllegalStateException modulesDirectoryDoesNotExist(File f);

      Message with same Id also in:

      jboss-eap-6.0-src/host-controller/src/main/java/org/jboss/as/host/controller/HostControllerMessages.java
      @Message(id = 15848, value = "Determined modules directory does not exist: %s")
      IllegalStateException modulesDirectoryDoesNotExist(File f);

      same for Id 15849 in HostControllerMessages. Messages should have different Id.


      Id: 15850-15857, 15860-15864
      Subsystem Id Range:
      Host Controller (host packages) = 10900 - 10999
      Server = 15700 - 15999, 18700 - 18799

      Correct:

      jboss-eap-6.0-src/server/src/main/java/org/jboss/as/server/ServerLogger.java
      @LogMessage(level = WARN)
      @Message(id = 15850, value = "%s in subdeployment ignored. jboss-deployment-structure.xml is only parsed for top level deployments.")
      void jbossDeploymentStructureIgnored(String file);

      Message with same Id also in:

      jboss-eap-6.0-src/host-controller/src/main/java/org/jboss/as/host/controller/HostControllerMessages.java
      @Message(id = 15850, value = "Domain base directory is not a directory: %s")
      IllegalStateException domainBaseDirectoryIsNotADirectory(File file);

      so on for 15851 - 15857, 15860 - 15864 in HostControllerMessages. Messages should have different Id.
      some wrong Id's also in ServerLogger: 18558, 18559, 18562, 18565 - 18569


      Id: 15873, 15874
      Subsystem Id Range:
      Host Controller (domain packages) = 10800 - 10899
      Server = 15700 - 15999, 18700 - 18799

      Correct:

      jboss-eap-6.0-src/server/src/main/java/org/jboss/as/server/ServerLogger.java
      @LogMessage(level = ERROR)
      @Message(id = 15873, value = "Cannot add module '%s' as URLStreamHandlerFactory provider")
      void cannotAddURLStreamHandlerFactory(@Cause Exception cause, String moduleID);

      Message with same Id also in:

      jboss-eap-6.0-src/host-controller/src/main/java/org/jboss/as/domain/controller/DomainControllerMessages.java
      @Message(id = 15873, value = "Repository does not contain any deployment with hash %s")
      IllegalStateException deploymentHashNotFoundInRepository(String hash);

      same for Id 15874 in DomainControllerMessages. Messages should have different Id.


      Id: 18558, 18559, 18562, 18565 - 18569
      Subsystem Id Range:
      CMP = 10700 - 10799, 18500 - 18699, 18800 - 18999
      Server = 15700 - 15999, 18700 - 18799

      Correct:

      jboss-eap-6.0-src/cmp/src/main/java/org/jboss/as/cmp/CmpMessages.java
      @Message(id = 18558, value = "Entity state is null.")
      IllegalStateException entityStateIsNull();

      Message with same Id also in:

      jboss-eap-6.0-src/server/src/main/java/org/jboss/as/server/ServerLogger.java
      @LogMessage(level = INFO)
      @Message(id = 18558, value = "Undeployed \"%s\"")
      void deploymentUndeployed(String deploymentName);

      so on for 18559, 18562, 18565 - 18569 in ServerLogger. Messages should have different Id.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                jamezp James Perkins
                Reporter:
                pkremens Petr Kremensky
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: