Uploaded image for project: 'Tools (JBoss Tools)'
  1. Tools (JBoss Tools)
  2. JBIDE-11614

Non-labeled Checkboxes in property dialogs have weird selection rectangle

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • 4.2.0.Beta1
    • 3.3.0.Beta3
    • common, upstream
    • None

      Add CDI facet for some project. Click on 'Further configuration available'. Dialog provides checking/unchecking generating beans.xml file. Next to this checkbox there is some invisible selected rectangle.

        1. 01_issue.png
          01_issue.png
          99 kB
        2. workaround.jpg
          workaround.jpg
          55 kB

            [JBIDE-11614] Non-labeled Checkboxes in property dialogs have weird selection rectangle

            Amol Dongare made changes -
            Workflow Original: GIT Pull Request workflow [ 12505524 ] New: GIT Pull Request workflow v1.0 [ 14225493 ]

            Verified with JBDS 8.0.0.Beta1-v20140323-1410-B78

            Vlado Pakan (Inactive) added a comment - Verified with JBDS 8.0.0.Beta1-v20140323-1410-B78
            Vlado Pakan (Inactive) made changes -
            Status Original: Resolved [ 5 ] New: Closed [ 6 ]

            Marked as resolved for Beta-1 then. But we have to verify the fix before closing the jira.

            Alexey Kazakov added a comment - Marked as resolved for Beta-1 then. But we have to verify the fix before closing the jira.
            Alexey Kazakov made changes -
            Fix Version/s New: 4.2.0.Beta1 [ 12323828 ]
            Fix Version/s Original: LATER [ 12311660 ]
            Resolution New: Done [ 1 ]
            Status Original: Open [ 1 ] New: Resolved [ 5 ]

            BugZilla states that Bug 314815 (Checkbox with null text will display a empty rectangle) is RESOLVED as FIXED with Target Milestone 4.4m6

            Victor Rubezhny (Inactive) added a comment - BugZilla states that Bug 314815 (Checkbox with null text will display a empty rectangle) is RESOLVED as FIXED with Target Milestone 4.4m6

            I've proposed a fix for checkboxes with empty labels to SWT/GTK org.eclipse.swt.widgets.Button class. The Button class is changed to control the visibility of box, label and image widgets due to hide all the three widgets in case of empty label and image at the same time.

            The commit is pushed to Gerrit here: https://git.eclipse.org/r/19165

            Victor Rubezhny (Inactive) added a comment - - edited I've proposed a fix for checkboxes with empty labels to SWT/GTK org.eclipse.swt.widgets.Button class. The Button class is changed to control the visibility of box, label and image widgets due to hide all the three widgets in case of empty label and image at the same time. The commit is pushed to Gerrit here: https://git.eclipse.org/r/19165
            Vlastimil Eliáš made changes -
            Workflow Original: jira [ 12491709 ] New: GIT Pull Request workflow [ 12505524 ]
            Alexey Kazakov made changes -
            Fix Version/s New: LATER [ 12311660 ]
            Fix Version/s Original: 3.3.0.Beta3 [ 12316352 ]
            Victor Rubezhny (Inactive) made changes -
            Component/s New: common/jst/core [ 12311404 ]
            Component/s New: UpStream [ 12311230 ]
            Component/s Original: CDI [ 12311967 ]
            Summary Original: In cdi facet properties dialog there is weird selection rectangle New: Non-labeled Checkboxes in property dialogs have weird selection rectangle
            Victor Rubezhny (Inactive) made changes -
            Attachment New: workaround.jpg [ 12353612 ]

            There is known issue on non-labeled checkbox in BugZilla: https://bugs.eclipse.org/bugs/show_bug.cgi?id=314815

            The possible workaround is to replace non-labeled chechboxes by the labeled ones (see 'workaround' screenshot for example)

            Victor Rubezhny (Inactive) added a comment - There is known issue on non-labeled checkbox in BugZilla: https://bugs.eclipse.org/bugs/show_bug.cgi?id=314815 The possible workaround is to replace non-labeled chechboxes by the labeled ones (see 'workaround' screenshot for example)
            Victor Rubezhny (Inactive) made changes -
            Environment New: Linux

            This 'invisible selected range' actually is empty label of check box editor. It exists in any our non-labeled check box editors on many property pages (for example see: '<Project Properties>=>Seam Settings=>Seam Support' check box or '<Project Properties>=>JBoss Tools Knowledge Base=>JBoss Tools Knowledge Base support' check box.

            Standard concept in Eclipse is to place the label at right of check box. If the label is separated of the check box (and as such, the check box's label is empty) it's label is still shown at right (actually, the only placeholder is drawn).

            Victor Rubezhny (Inactive) added a comment - - edited This 'invisible selected range' actually is empty label of check box editor. It exists in any our non-labeled check box editors on many property pages (for example see: '<Project Properties>=>Seam Settings=>Seam Support' check box or '<Project Properties>=>JBoss Tools Knowledge Base=>JBoss Tools Knowledge Base support' check box. Standard concept in Eclipse is to place the label at right of check box. If the label is separated of the check box (and as such, the check box's label is empty) it's label is still shown at right (actually, the only placeholder is drawn).
            Alexey Kazakov made changes -
            Assignee Original: Alexey Kazakov [ alexeykazakov ] New: Victor Rubezhny [ vrubezhny ]
            Jaroslav Jankovič (Inactive) made changes -
            Attachment New: 01_issue.png [ 12353565 ]
            Jaroslav Jankovič (Inactive) created issue -

              vrubezhny Victor Rubezhny (Inactive)
              jjankovi Jaroslav Jankovič (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: