Uploaded image for project: 'JBoss Enterprise Application Platform'
  1. JBoss Enterprise Application Platform
  2. JBEAP-7785

Dead code in DefaultFilenameTabCompleter - completeCandidates

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Major
    • 7.1.0.DR10
    • 7.1.0.DR9
    • CLI
    • None

    Description

      https://github.com/wildfly/wildfly-core/blob/master/cli/src/main/java/org/jboss/as/cli/handlers/DefaultFilenameTabCompleter.java#L65

      needsEscape = needsEscape || containsQuote;
....
EscapeSelector escSelector = containsQuote && !needsEscape
? QUOTES_ONLY_ESCAPE_SELECTOR : ESCAPE_SELECTOR;

      QUOTES_ONLY_ESCAPE_SELECTOR will be never used, because containsQuote would have to be true and needsEscape false. But because of needsEscape = needsEscape || containsQuote needsEscape will be always true when containsQuote is true.

      Attachments

        Issue Links

          is cloned by

          Bug - A problem that impairs or prevents the functions of the product. WFCORE-2120 Dead code in DefaultFilenameTabCompleter - completeCandidates

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Resolved
          is incorporated by

          Component Upgrade - A task tracking an update to a bundled component or revision of component upstream of the project. JBEAP-7572 (7.1.0) Upgrade to WildFly Core 3.0.0.Alpha17

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Verified

          Activity

            People

              jdenise@redhat.com Jean Francois Denise
              rsvoboda@redhat.com Rostislav Svoboda
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: