Uploaded image for project: 'JBoss Enterprise Application Platform'
  1. JBoss Enterprise Application Platform
  2. JBEAP-19690

[GSS](7.3.z) JBTM-3337 - IllegalArgumentException: key can't be empty from jbossts-properties.xml

    XMLWordPrintable

Details

    Description

      If JBoss is started with a -D it will fail to start. The JDK has no problem allowing -D and returns this with a property name of "" , It would be good to skip if key is empty to prevent failing.

      narayana-jts-idlj-5.9.6.Final-redhat-00001.jar/com/arjuna/common/util/propertyservice/AbstractPropertiesFactory.class

      private Properties applySystemProperties(Properties inputProperties) {
      Properties outputProperties = new Properties(inputProperties);
      Enumeration enumeration = System.getProperties().propertyNames();
      while (enumeration.hasMoreElements())

      { String key = (String)enumeration.nextElement(); outputProperties.setProperty(key, System.getProperty(key)); }


      return outputProperties;
      }
      https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/System.html#getProperty(java.lang.String)

      09:40:28,876 ERROR [org.jboss.as.controller.management-operation] (ServerService Thread Pool -- 78) WFLYCTL0013: Operation ("add") failed - address: ([("subsystem" => "transactions")]): java.lang.RuntimeException: java.lang.RuntimeException: unable to load properties from jar:file:/tmp/jboss-eap-7.3/modules/system/layers/base/org/jboss/jts/main/narayana-jts-idlj-5.9.8.Final-redhat-00002.jar!/jbossts-properties.xml
	at com.arjuna.common.internal.util.propertyservice.BeanPopulator.getNamedInstance(BeanPopulator.java:90)
	at com.arjuna.common.internal.util.propertyservice.BeanPopulator.getDefaultInstance(BeanPopulator.java:53)
	at com.arjuna.ats.jta.common.jtaPropertyManager.getJTAEnvironmentBean(jtaPropertyManager.java:42)
	at org.jboss.as.txn.service.JTAEnvironmentBeanService.getValue(JTAEnvironmentBeanService.java:91)
	at org.jboss.as.txn.subsystem.TransactionSubsystemAdd.performRecoveryEnvBoottime(TransactionSubsystemAdd.java:489)
	at org.jboss.as.txn.subsystem.TransactionSubsystemAdd.performBoottime(TransactionSubsystemAdd.java:248)
	at org.jboss.as.controller.AbstractBoottimeAddStepHandler.performBoottime(AbstractBoottimeAddStepHandler.java:144)
	at org.jboss.as.controller.AbstractBoottimeAddStepHandler.performRuntime(AbstractBoottimeAddStepHandler.java:119)
	at org.jboss.as.controller.AbstractAddStepHandler.execute(AbstractAddStepHandler.java:159)
	at org.jboss.as.controller.AbstractOperationContext.executeStep(AbstractOperationContext.java:999)
	at org.jboss.as.controller.AbstractOperationContext.processStages(AbstractOperationContext.java:743)
	at org.jboss.as.controller.AbstractOperationContext.executeOperation(AbstractOperationContext.java:467)
	at org.jboss.as.controller.ParallelBootOperationStepHandler$ParallelBootTask.run(ParallelBootOperationStepHandler.java:384)
	at org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35)
	at org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1982)
	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1486)
	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1348)
	at java.lang.Thread.run(Thread.java:748)
	at org.jboss.threads.JBossThread.run(JBossThread.java:485)
Caused by: java.lang.RuntimeException: unable to load properties from jar:file:/tmp/jboss-eap-7.3/modules/system/layers/base/org/jboss/jts/main/narayana-jts-idlj-5.9.8.Final-redhat-00002.jar!/jbossts-properties.xml
	at com.arjuna.common.util.propertyservice.AbstractPropertiesFactory.getPropertiesFromFile(AbstractPropertiesFactory.java:107)
	at com.arjuna.common.util.propertyservice.AbstractPropertiesFactory.initDefaultProperties(AbstractPropertiesFactory.java:195)
	at com.arjuna.common.util.propertyservice.AbstractPropertiesFactory.getDefaultProperties(AbstractPropertiesFactory.java:62)
	at com.arjuna.common.util.propertyservice.PropertiesFactory.getDefaultProperties(PropertiesFactory.java:48)
	at com.arjuna.common.internal.util.propertyservice.BeanPopulator.getNamedInstance(BeanPopulator.java:86)
	... 18 more
Caused by: java.lang.IllegalArgumentException: key can't be empty
	at java.lang.System.checkKey(System.java:841)
	at java.lang.System.getProperty(System.java:714)
	at com.arjuna.common.util.propertyservice.AbstractPropertiesFactory.applySystemProperties(AbstractPropertiesFactory.java:124)
	at com.arjuna.common.util.propertyservice.AbstractPropertiesFactory.getPropertiesFromFile(AbstractPropertiesFactory.java:104)
	... 22 more

      Attachments

        Issue Links

          clones

          Bug - A problem that impairs or prevents the functions of the product. JBTM-3337 Narayana startup fails when empty system property is provided

          • Minor - To be worked after urgent, high, and medium priorities are resolved. This term is chosen when the severity of the issue is low, or the complexity or effort to correct it may be higher, relatively speaking. For low priority issues, known workarounds exist or are not needed due to the trivial effort needed to address the issue.
          • Closed
          is incorporated by

          Component Upgrade - A task tracking an update to a bundled component or revision of component upstream of the project. JBEAP-19789 [GSS](7.3.z) Upgrade Narayana from 5.9.8.Final to 5.9.9.Final

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Activity

            People

              rchakrab Ranabir Chakraborty
              rhn-support-bmaxwell Brad Maxwell
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: