• Type: Bug
• Resolution: Done
• Priority: Major
• Fix Version/s: 9.3.4.Final, 9.4.0.Final
• Affects Version/s: 9.2.0.Final
• Component/s: Core, Embedded Querying, Server
• Labels:

  None

[ISPN-9559] Server <modules> configuration with a single entry can break classloading

Adrian Nistor (Inactive) created issue - 2018/09/28 10:03 AM

Adrian Nistor (Inactive) made changes - 2018/09/28 10:04 AM

Status

Original: New [ 10016 ]

New: Open [ 1 ]

Adrian Nistor (Inactive) made changes - 2018/09/28 10:05 AM

Git Pull Request		New: https://github.com/infinispan/infinispan/pull/6286
Status	Original: Open [ 1 ]	New: Pull Request Sent [ 10011 ]

Adrian Nistor (Inactive) made changes - 2018/09/28 12:36 PM

Description

New: There's a bug in CacheContainerConfigurationBuilder introduced by changes for ISPN-7714. This happens only if we have a single module entry specified in the <modules> element of the cache container config or if we have a non-empty 'module' attribute. The classloader of the specified module is used as the global classloader of the cache container. This is almost always wrong. We should instead have an AggregatedClassloader of the user specified classloader in module/modules + the infinispan subsystem classloader. If no module is specified then the infinispan subsystem classloader should be used.

Adrian Nistor (Inactive) made changes - 2018/10/01 5:26 AM

Summary

Original: Server <modules> configuration with a single entry breaks classloading

New: Server <modules> configuration with a single entry can break classloading

Adrian Nistor (Inactive) made changes - 2018/10/01 6:17 AM

Description

Original: There's a bug in CacheContainerConfigurationBuilder introduced by changes for ISPN-7714. This happens only if we have a single module entry specified in the <modules> element of the cache container config or if we have a non-empty 'module' attribute. The classloader of the specified module is used as the global classloader of the cache container. This is almost always wrong. We should instead have an AggregatedClassloader of the user specified classloader in module/modules + the infinispan subsystem classloader. If no module is specified then the infinispan subsystem classloader should be used.

New: There's a bug in CacheContainerConfigurationBuilder introduced by changes for ISPN-7714. This happens only if we have a _single_ module entry specified in the <modules> element of the cache container config and nothing in the 'module' attribute. In that case the module is used as if it was specified in the 'module' attribute. The classloader of the specified module is used as the global classloader of the cache container and this is almost always wrong. We should instead have an AggregatedClassloader of the classloaders of the user specified module/modules + the infinispan subsystem classloader (if no module attribute is present). If a 'module' attribute was specified then we should let that module be the designated classloader and do not use infinispan subsystem classloader as backup.

Gustavo Fernandes (Inactive) made changes - 2018/10/03 5:12 AM

Resolution		New: Done [ 1 ]
Status	Original: Pull Request Sent [ 10011 ]	New: Resolved [ 5 ]

Adrian Nistor (Inactive) made changes - 2018/10/09 1:12 PM

Git Pull Request

Original: https://github.com/infinispan/infinispan/pull/6286

New: https://github.com/infinispan/infinispan/pull/6286, https://github.com/infinispan/infinispan/pull/6328

Adrian Nistor (Inactive) made changes - 2018/10/09 1:12 PM

Fix Version/s

New: 9.3.4.Final [ 12339151 ]

Gustavo Lira Silva made changes - 2018/10/31 11:21 AM

Status

Original: Resolved [ 5 ]

New: Closed [ 6 ]

Pedro Zapata Fernandez made changes - 2023/11/16 2:33 PM

Workflow

Original: GIT Pull Request with Triage workflow [ 12930019 ]

New: OJA-WF-BG [ 24697400 ]