Uploaded image for project: 'Infinispan'
  1. Infinispan
  2. ISPN-4159

DefaultTwoWayKey2StringMapper encodes objects to strings in a manner that is incompatible with string handling of some databases

    Details

    • Type: Bug
    • Status: Open (View Workflow)
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 6.0.0.Final
    • Fix Version/s: None
    • Component/s: Loaders and Stores
    • Labels:
      None

      Description

      DefaultTwoWayKey2StringMapper uses two neat tricks.
      1. it does not encode all supported types, it only encodes non-Strings. Strings are kept unmodified.
      2. it uses a special prefix (unicode char 0xfeff) to mark which strings were encoded and which are plain.

      Unfortunately some databases, notably MySql, interpret the endianness mark (0xfeff, 0xfffe), convert to native byte order and then drop it.

      This leaves us with no clue the string is not an actual String but an encoded representation of another type. This misinterpretation leads later to ClassCastExceptions in various places in core and user code.

      Proposed fix: get rid of #1 and #2 optimisations. Encode all objects, including Strings and always use the ?n prefix (where n stands for the original type). Drop the 0xFEFF marker prefix.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  ryanemerson Ryan Emerson
                  Reporter:
                  anistor Nistor Adrian
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated: