Uploaded image for project: 'Insights Experiences'
  1. Insights Experiences
  2. HMS-708

Launching shows error but continues

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Undefined Undefined
    • hms-0.5
    • None
    • Provisioning
    • None
    • None

      See this recording: https://mmarusak.fedorapeople.org/errorandcontinue.gif

      So the issue is that it both shows some error about already existing key but also that it then continues to run. Neither of these two should happen.

            [HMS-708] Launching shows error but continues

            Akhil Jha added a comment -

            Verified

            Akhil Jha added a comment - Verified

            Lukáš Zapletal added a comment -

            https://github.com/RHEnVision/provisioning-backend/pull/344

            Lukáš Zapletal added a comment - https://github.com/RHEnVision/provisioning-backend/pull/344

            Lukáš Zapletal added a comment -

            I believe we also need to expand our reservation model. We track amount of steps, current step and one error, however, more than one job step can fail. Therefore I suggest to change Error to Errors []string so it can track multiple errors. When on it, I also suggest to put StepTitles []string that will contain titles (descriptions) of all steps for UI. With this change, in UI we can render much better output in some sort of "list" of steps:

            • Ensure public key is present
            • Launch instance on AWS

            And as the reservation progresses, we can "mark" those as done (or as an error allowing showing error message for each step).

            In summary, I would work on a PR that refactors one field and adds a new field. Both being SQL arrays, something that Postgres with pgx supports natively out of the box. Opinions?

            Lukáš Zapletal added a comment - I believe we also need to expand our reservation model. We track amount of steps, current step and one error, however, more than one job step can fail. Therefore I suggest to change Error to Errors []string so it can track multiple errors. When on it, I also suggest to put StepTitles []string that will contain titles (descriptions) of all steps for UI. With this change, in UI we can render much better output in some sort of "list" of steps: Ensure public key is present Launch instance on AWS And as the reservation progresses, we can "mark" those as done (or as an error allowing showing error message for each step). In summary, I would work on a PR that refactors one field and adds a new field. Both being SQL arrays, something that Postgres with pgx supports natively out of the box. Opinions?

            Ondrej Ezr added a comment -

            This is caused by backend proceeding the Launch even when there is error in one of the jobs. We need to fix this in backend job scheduler.

            Ondrej Ezr added a comment - This is caused by backend proceeding the Launch even when there is error in one of the jobs. We need to fix this in backend job scheduler.

              rhn-engineering-lzapletal Lukáš Zapletal
              mmarusak Matej Marušák
              None
              None
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: