Uploaded image for project: 'GateIn Portal'
  1. GateIn Portal
  2. GTNPORTAL-3322

Improvements of handling of <priority> in navigation.xml

    Details

    • Type: Task
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 3.7.0.Final
    • Component/s: None
    • Labels:
      None

      Description

      This is followup of GTNPORTAL-2751, GTNPORTAL-3324 and GTNPORTAL-3350.

      (1) Introduce PageNavigation.UNDEFINED_PRIORITY constant and use it instead of -1 literal as PageNavigation.priority value.

      (2) UNDEFINED_PRIORITY and its usage should be described in comments.

      (3) Fix the comparator in UserPortalImpl as it does not impose a total ordering as required by the Comparator interface: "The implementor must ensure that sgn(compare(x, y)) == -sgn(compare(y, x)) for all x and y." This does not hold when comparing two nodes both having priority -1.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                ppalaga Peter Palaga
                Reporter:
                ppalaga Peter Palaga
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 4 hours
                  4h
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour Time Not Required
                  1h