Uploaded image for project: 'GateIn Portal'
  1. GateIn Portal
  2. GTNPORTAL-2751

<priority> in navigation.xml files ignored for merge importMode

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 3.7.0.Final
    • Component/s: None
    • Labels:
      None

      Description

      Steps to reproduce:

      Clone the Portal Extension Quickstart and deploy it changing the <priority> value in war/src/main/webapp/WEB-INF/conf/sample-ext/portal/group/platform/administrators/navigation.xml.
      NOT OK: The changes have no effect, because priority is ignored in org.exoplatform.portal.mop.importer.NavigationImporter.perform() with importMode merge.

      Solution Proposal A

      • Make <priority> optional in gatein_objects XSD and NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)
      • Explicitly state in the documentation [1] that <priority> is considered only if not already set (first wins).

      Solution Proposal B

      • Make <priority> optional in gatein_objects XSD and NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>)
      • Change the behavior of NavigationMarshaller.unmarshalNavigation(StaxNavigator<Element>) to the effect that <priority> is handled in the same way as navigation nodes: it is used or ignored according to the chosen importMode. Esp. for importMode merge the last read <priority> should win.
      • Document it in [1]

      For both A and B the most or all occutences of <priority> should be removed from Portal Extension Quickstart.

      [1] https://docs.jboss.org/author/display/GTNPORTAL35/Portal+Navigation+Configuration

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  trong.tran Trong Tran
                  Reporter:
                  ppalaga Peter Palaga
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Time Tracking

                    Estimated:
                    Original Estimate - 6 hours Original Estimate - 6 hours
                    6h
                    Remaining:
                    Remaining Estimate - 0 minutes
                    0m
                    Logged:
                    Time Spent - 2 days
                    2d