Uploaded image for project: 'Errai'
  1. Errai
  2. ERRAI-848

BindableListWrapper contains() calls convertToProxy() even for already proxied items

    Details

    • Workaround:
      Workaround Exists
    • Workaround Description:
      Hide
          private boolean bindableListContains(M oldItem) {
              if (oldItem == null) return false;
              Iterator<M> iter = bindableList.iterator();
              while (iter.hasNext()) {
                  M i = iter.next();
                  if (i.equals(oldItem)) return true;
              }
              return false;
          }
      
      Show
      private boolean bindableListContains(M oldItem) { if (oldItem == null ) return false ; Iterator<M> iter = bindableList.iterator(); while (iter.hasNext()) { M i = iter.next(); if (i.equals(oldItem)) return true ; } return false ; }

      Description

      convertToProxy() must not be called for already proxied objects, because it leads to excessive PropertyChangeHandler creation and registration.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                csa Christian Sadilek
                Reporter:
                slavap Slava Pankov
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: