Uploaded image for project: 'Red Hat OpenShift Dev Spaces (formerly CodeReady Workspaces) '
  1. Red Hat OpenShift Dev Spaces (formerly CodeReady Workspaces)
  2. CRW-2256

Can't delete checluster CR when KIP is enabled

    XMLWordPrintable

Details

    • False
    • False
    • Hide
      = Uninstalling {prod-short} fails when the {image-puller-name} is installed

      When the {image-puller-name} is installed, uninstalling {prod-short} fails, meaning:

      * The deletion process doesn't remove the {image-puller-name} finalizer.
      * The `CheCluster` Custom Resource is not empty and can't be removed.

      .Workaround

      * Disable the {image-puller-name} before uninstalling {prod-short}.

      // Cause: When spec.imagePuller.enable is set to true, KIP finalizer was not being removed from the CheCluster CR on deletion.
      // Consequence: When user tries to delete the CheCluster CR, it would not delete.
      // Fix: Delete the KIP finalizer on CR deletion.
      // Result: CheCluster CR deletes properly.
      Show
      = Uninstalling {prod-short} fails when the {image-puller-name} is installed When the {image-puller-name} is installed, uninstalling {prod-short} fails, meaning: * The deletion process doesn't remove the {image-puller-name} finalizer. * The `CheCluster` Custom Resource is not empty and can't be removed. .Workaround * Disable the {image-puller-name} before uninstalling {prod-short}. // Cause: When spec.imagePuller.enable is set to true, KIP finalizer was not being removed from the CheCluster CR on deletion. // Consequence: When user tries to delete the CheCluster CR, it would not delete. // Fix: Delete the KIP finalizer on CR deletion. // Result: CheCluster CR deletes properly.
    • Hide

      Install CRW with KIP enabled.
      Wait for everything to be installed
      Try to delete checluster CR -> this should uninstall CRW (and KIP as well?), but it doesn't.

      Show
      Install CRW with KIP enabled. Wait for everything to be installed Try to delete checluster CR -> this should uninstall CRW (and KIP as well?), but it doesn't.

    Description

        I can't delete checluster CR when KIP is enabled.
      che-operator logs: http://pastebin.test.redhat.com/992915
      Snippet of logs:

      time="2021-09-09T13:35:22Z" level=info msg="Delete initial user: codeready"
time="2021-09-09T13:35:22Z" level=info msg="Delete initial user identity: htpasswd-eclipse-che:codeready"
time="2021-09-09T13:35:22Z" level=info msg="Delete initial user httpasswd provider from the oAuth"
I0909 13:35:23.961918       1 request.go:655] Throttling request took 1.044228034s, request: GET:https://172.30.0.1:443/apis/operators.coreos.com/v2?timeout=32s
I0909 13:35:34.009680       1 request.go:655] Throttling request took 3.397082384s, request: GET:https://172.30.0.1:443/apis/authorization.k8s.io/v1beta1?timeout=32s
time="2021-09-09T13:35:35Z" level=error msg="CheCluster.org.eclipse.che \"codeready-workspaces\" is invalid: metadata.finalizers: Forbidden: no new finalizers can be added if the object is being deleted, found new finalizers []string{\"cheWorkspaces.clusterpermissions.finalizers.che.eclipse.org\"}"
{"level":"error","ts":1631194535.0965853,"logger":"controller","msg":"Reconciler error","reconcilerGroup":"org.eclipse.che","reconcilerKind":"CheCluster","controller":"checluster","name":"codeready-workspaces","namespace":"rhopp-crw-kip","error":"CheCluster.org.eclipse.che \"codeready-workspaces\" is invalid: metadata.finalizers: Forbidden: no new finalizers can be added if the object is being deleted, found new finalizers []string{\"cheWorkspaces.clusterpermissions.finalizers.che.eclipse.org\"}","stacktrace":"github.com/go-logr/zapr.(*zapLogger).Error\n\t/che-operator/vendor/github.com/go-logr/zapr/zapr.go:132\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/che-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:246\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/che-operator/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:218\nsigs.k8s.io/controller-runtime...

      Attachments

        Issue Links

          relates to

          Feature Request - Feature requests from customers and/or users CRW-2064 Feature: New KIP implementation pulls image directly from operator CSV (default list updates with each operator update)

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed
          links to

          GitHub eclipse-che/che-operator#1082: fix: delete KIP finalizer and KIP operator on CheCluster CR delete

          Activity

            People

              dakwon@redhat.com David Kwon
              rhopp@redhat.com Radim Hopp
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: