-
Sub-task
-
Resolution: Done
-
Major
-
2.8.0.GA
-
None
-
False
-
False
-
Undefined
-
get-sources-jenkins.sh has:
DEV_WORKSPACE_CONTROLLER_VERSION="0.1.x" # or "main" DEV_WORKSPACE_CHE_OPERATOR_VERSION="7.27.x" # or "main"
These vars should be exposed to Jenkins so we can pass the correct version in from crw-operator.groovy.
By doing so, we can ensure that the version hardcoded into the Dockerfile is the same in both crw-images and pkgs.devel repos:
- https://github.com/redhat-developer/codeready-workspaces-images/blob/crw-2-rhel-8/codeready-workspaces-operator/Dockerfile#L16-L17 (main)
- http://pkgs.devel.redhat.com/cgit/containers/codeready-workspaces-operator/tree/Dockerfile?h=crw-2-rhel-8#n16 (0.1.x / 7.27.x)
Alternatively, we could simply scrub the vars from the Dockerfile via sed replacement...
crw-operator_2.x.jenkinsfile
# CRW-1655 apply patches to support fetching sources directly from DWO and DWCO upstream projects sed -i ${TARGET_DIR}/Dockerfile -r \ -e "s#RUN curl .+/tmp/((devworkspace|devworkspace-che)-operator.zip)(.+)#COPY \\1 /tmp#g" \ -e "s# +(unzip /tmp/.+)#RUN \\1#g" ...(add more replacements here)...
But then we run the risk of pulling the wrong branch of sources (forgetting to update the get-sources script).
So probably better to make sure that the copy of Dockerfile in crw-images has 0.1.x / 7.27.x instead of main / main.