• False
    • False
    • Undefined

      get-sources-jenkins.sh has:

      DEV_WORKSPACE_CONTROLLER_VERSION="0.1.x" # or "main"
      DEV_WORKSPACE_CHE_OPERATOR_VERSION="7.27.x" # or "main"
      

      These vars should be exposed to Jenkins so we can pass the correct version in from crw-operator.groovy.

      By doing so, we can ensure that the version hardcoded into the Dockerfile is the same in both crw-images and pkgs.devel repos:

      Alternatively, we could simply scrub the vars from the Dockerfile via sed replacement...

      crw-operator_2.x.jenkinsfile
      # CRW-1655 apply patches to support fetching sources directly from DWO and DWCO upstream projects
      sed -i ${TARGET_DIR}/Dockerfile -r \
        -e "s#RUN curl .+/tmp/((devworkspace|devworkspace-che)-operator.zip)(.+)#COPY \\1 /tmp#g" \
        -e "s# +(unzip /tmp/.+)#RUN \\1#g"
      ...(add more replacements here)...
      

      But then we run the risk of pulling the wrong branch of sources (forgetting to update the get-sources script).

      So probably better to make sure that the copy of Dockerfile in crw-images has 0.1.x / 7.27.x instead of main / main.

              nickboldt Nick Boldt
              nickboldt Nick Boldt
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Created:
                Updated:
                Resolved: