Uploaded image for project: 'OpenShift Virtualization'
  1. OpenShift Virtualization
  2. CNV-71129

Fix snapshot controller to requeue when PVC finalizer removal fails

XMLWordPrintable

    • 3
    • False
    • Hide

      None

      Show
      None
    • False
    • None
    • CNV Storage Sprint 280
    • None

      Test Clone from volumesnapshot source sourceRef support  failed in 4.20 run:
      https://jenkins-csb-cnvqe-main.dno.corp.redhat.com/job/test-cdi-cnv-4.20-ocs/49/testReport/(root)/Tests%20Suite/_It__all_clone_tests__rfe_id_9453__Clone_from_volumesnapshot_source_sourceRef_support__test_id_9758__Should_clone_data_from_SourceRef_snapshot_DataSource_with_size_specified_on_target/

      The failure was caused by the snapshot controller not retrying after a PVC finalizer removal error.
      When checkandRemovePVCFinalizer() fails (e.g., with “object has been modified; please apply your changes to the latest version and try again”), the error is only logged and not returned, so the reconciliation loop does not requeue the snapshot for another attempt.
      This results in PVC finalizers remaining on the object and snapshots stuck in a terminating or pending state.

              rh-ee-dsanatar Danny Sanatar
              dafrank@redhat.com Dalia Frank
              Natalie Gavrielov Natalie Gavrielov
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: