Uploaded image for project: 'Cloud Enablement'
  1. Cloud Enablement
  2. CLOUD-1879

[Common] getfiles script broke original assumptions, breaks json logging

    XMLWordPrintable

Details

    • 1
    • Release Notes
    • Hide
      Cause: original getfiles() was replaced to include jar search for .overlays and lost ability to return a colon delimited list of jars
      Consequence: javax.json jar was missing from boot classpath which broke json logging
      Fix: getfiles() returns a colon-delimited list of jars if passed a directory
      Result: javax.json jar is now included in the boot classpath
      Show
      Cause: original getfiles() was replaced to include jar search for .overlays and lost ability to return a colon delimited list of jars Consequence: javax.json jar was missing from boot classpath which broke json logging Fix: getfiles() returns a colon-delimited list of jars if passed a directory Result: javax.json jar is now included in the boot classpath
    • CLOUD Maintenance Sprint 9

    Description

      The getfiles method in EAP scripts was changed to handle overlays however the functionality of the method was also changed and now breaks the original json logging code.

      The original getfiles method created a classpath from all jars within the directory, separating them with a ':', whereas the current implementation will only output the first jar found.

      The original invocation of this method was

      JBOSS_LOGMANAGER_JAR=$(getfiles $JBOSS_HOME/modules/system/layers/base/org/jboss/logmanager/main/)
JBOSS_LOGMANAGER_EXT_JAR=$(getfiles $JBOSS_HOME/modules/system/layers/base/org/jboss/logmanager/ext/main/)

      whereas the new invocation of this method is

      JBOSS_LOGMANAGER_JAR=$(getfiles org/jboss/logmanager/main/jboss-logmanager)
JBOSS_LOGMANAGER_EXT_JAR=$(getfiles org/jboss/logmanager/ext/main/jboss-logmanager-ext)

      Note the change from the module directory to the more explicit filename

      The classpath for the logmanaged extension should be 

      <dir>/javax.json-1.0.4.jar:<dir>/jboss-logmanager-ext-1.0.0.Alpha2-redhat-1.jar

      Attachments

        Issue Links

          relates to

          Enhancement - An enhancement to or refactoring of existing functionality that is not configurable by an end user (typically a change made by an internal team that affects users) CLOUD-2152 [tracker] Sprint 12 release

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Closed

          Activity

            People

              wdecoste1@redhat.com William Decoste (Inactive)
              kconner@redhat.com Kevin Conner (Inactive)
              Petr Nehyba Petr Nehyba (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: