Uploaded image for project: 'OpenShift BuildConfig'
  1. OpenShift BuildConfig
  2. OCPBUILD-64

Use subcommands with openshift/builder

    XMLWordPrintable

Details

    • Story
    • Resolution: Won't Do
    • Normal
    • None
    • None
    • None
    • False
    • False

    Description

      User Story

      As an OpenShift engineer
      I want to use subcommands with the openshift/builder binary
      So that builder integrates cleanly with the spf13/cobra libraries

      Acceptance Criteria

      • openshift/builder works with appropriate subcommands
      • Builds pass regression testing

      QE Impact

      Regression testing only

      Docs Impact

      None

      PX Impact

      None.

      Notes

      This was tech debt identified during the k8s 1.23 rebase. Kubernetes has new utilities to run Cobra commands with klog and other flags baked in.

      openshift/builder currently has a binary that is symlinked to make each "command" that is run during a build. This is not necessary and makes testing/debugging more difficult. Cobra has had first-class support for subcommands for quite some time now - using a single root command with subcommands will make it easier for newcomers to contribute.

      Attachments

        Activity

          People

            Unassigned Unassigned
            adkaplan@redhat.com Adam Kaplan
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              PagerDuty