-
Enhancement
-
Resolution: Done
-
Major
-
None
-
None
-
None
-
None
When sending message through UPS Console, SimplePush clients are not notified at all, because the console does not specify value for 'simple-push' property in the payload to /sender endpoint.
The /sender endpoint thus ignore the SimplePush variant.
I don't believe that's correct, because if someone specified a SimplePush variant in his application, he just wants those clients to be notified, thus potentially use default behavior, which is sending empty payload to SimplePushServer (be it our impl or Mozilla's one).
[AEROGEAR-6170] SimplePush clients are not notified unless 'simple-push' is specified when using /sender endpoint
Sebastien Blanc (Inactive)
added a comment - edewit@redhat.com You mean adding it to the UI ? 
Erik Jan de Wit
added a comment - I think a 'better' solution would be to add the simple-push attribute for sending with the console
Erik Jan de Wit
added a comment - I think a 'better' solution would be to add the simple-push attribute for sending with the console 
Lukáš Fryč (Inactive)
added a comment - Even though we can correct this in UPS Console, I would suggest to remove the null check here:
if (variant instanceof SimplePushVariant && message.getSimplePush() != null) { // SP needs the 'simple-push' be present, the 'message' (aka data) has no meanings here
Lukáš Fryč (Inactive)
added a comment - Even though we can correct this in UPS Console, I would suggest to remove the null check here:
if (variant instanceof SimplePushVariant && message.getSimplePush() != null ) {
// SP needs the 'simple-push' be present, the 'message' (aka data) has no meanings here
https://github.com/aerogear/aerogear-unifiedpush-server/blob/f94d249752545fc09ebd85d3ba35112a56a91030/push/src/main/java/org/jboss/aerogear/unifiedpush/message/SenderServiceImpl.java#L104-L105 
I was thinking just to add it to the message being send by the UI not really a field in the UI where you can change it. Something like message.simplePush = 'version=' new Date().getTime();