-
Bug
-
Resolution: Unresolved
-
Normal
-
None
-
netobserv-1.10-candidate
-
None
-
Quality / Stability / Reliability
-
False
-
-
None
-
None
-
None
-
None
-
NetObserv - Sprint 275, NetObserv - Sprint 276, NetObserv - Sprint 277, NetObserv - Sprint 278
-
None
-
None
-
None
Here: https://github.com/netobserv/netobserv-ebpf-agent/blob/main/.mk/bc.mk#L35
There's a wrong "s" to "packets_record", should be "packet_record"
To avoid these mistakes in the future we should expose this kind of information from the agent code and import it from the operator, as well as securing the bytecode generation process:
- Add in agent's code a list of map names (perhaps with their types?), either in the "config" package (which is already imported from the operator), or in a new package such as "maps".
- Import that from the operator to generate the list of maps, see https://github.com/netobserv/network-observability-operator/blob/main/internal/controller/ebpf/agent_controller.go#L347
- Add a new CI check in agent (invoked via `make test` here https://github.com/netobserv/netobserv-ebpf-agent/blob/main/Makefile#L163) that makes sure the list of maps matches what is defined in the bytecode generation (https://github.com/netobserv/netobserv-ebpf-agent/blob/main/.mk/bc.mk#L30) and the BPF map definitions (https://github.com/netobserv/netobserv-ebpf-agent/blob/main/bpf/maps_definition.h ) (not 100% sure how to write that, bash/awk is certainly an option)