Uploaded image for project: 'OpenShift Hive'
  1. OpenShift Hive
  2. HIVE-2954

PrivateLink: nil pointer panic for GCP spoke + AWS hub + preserveOnDelete

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Major Major
    • None
    • None
    • None
    • Quality / Stability / Reliability
    • False
    • Hide

      None

      Show
      None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      goroutine 10184 [running]:
      k8s.io/apimachinery/pkg/util/runtime.logPanic({0x9c0dad8, 0xc04538e390}, {0x823fbc0, 0xd06ebc0})
      	k8s.io/apimachinery@v0.33.3/pkg/util/runtime/runtime.go:132 +0xbc
      sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Reconcile.func1()
      	sigs.k8s.io/controller-runtime@v0.20.1/pkg/internal/controller/controller.go:105 +0x112
      panic({0x823fbc0?, 0xd06ebc0?})
      	runtime/panic.go:792 +0x132
      github.com/openshift/hive/pkg/controller/privatelink/actuator/awsactuator.(*AWSHubActuator).CleanupRequired(0x722419902c4a?, 0xc2317dc8b839bdef?)
      	github.com/openshift/hive/pkg/controller/privatelink/actuator/awsactuator/awshubactuator.go:108 +0x36
      github.com/openshift/hive/pkg/controller/privatelink.(*PrivateLink).cleanupRequired(0xc01c669920)
      	github.com/openshift/hive/pkg/controller/privatelink/privatelink.go:148 +0x28
      github.com/openshift/hive/pkg/controller/privatelink.(*PrivateLink).cleanupClusterDeployment(0xc01c669920)
      	github.com/openshift/hive/pkg/controller/privatelink/privatelink.go:157 +0xa7
      github.com/openshift/hive/pkg/controller/privatelink.(*PrivateLink).Reconcile(0xc01c669920, 0x1)
      	github.com/openshift/hive/pkg/controller/privatelink/privatelink.go:66 +0x1d2
      github.com/openshift/hive/pkg/controller/privatelink.(*PrivateLinkReconciler).Reconcile(0xc00862ab88, {0x70?, 0xc00031f008?}, {{{0xc03c390270?, 0xc03eca7a48?}, {0xc012d9d760?, 0x70?}}})
      	github.com/openshift/hive/pkg/controller/privatelink/privatelink_controller.go:164 +0x450
      github.com/openshift/hive/pkg/controller/utils.delayingReconciler.Reconcile({{0x9b9f2e0?, 0xc00862ab88?}, {0x9c4b080?, 0xc008636a80?}}, {0x9c0dad8?, 0xc04538e390?}, {{{0xc03c390270, 0x2f}, {0xc012d9d760, 0xb}}})
      	github.com/openshift/hive/pkg/controller/utils/delayingreconciler.go:36 +0x86
      sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Reconcile(0xc044c8b7c0?, {0x9c0dad8?, 0xc04538e390?}, {{{0xc03c390270?, 0x0?}, {0xc012d9d760?, 0x0?}}})
      	sigs.k8s.io/controller-runtime@v0.20.1/pkg/internal/controller/controller.go:116 +0xbf
      sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).reconcileHandler(0x9c38900, {0x9c0db10, 0xc000d5b130}, {{{0xc03c390270, 0x2f}, {0xc012d9d760, 0xb}}})
      	sigs.k8s.io/controller-runtime@v0.20.1/pkg/internal/controller/controller.go:303 +0x3a5
      sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).processNextWorkItem(0x9c38900, {0x9c0db10, 0xc000d5b130})
      	sigs.k8s.io/controller-runtime@v0.20.1/pkg/internal/controller/controller.go:263 +0x20d
      sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Start.func2.2()
      	sigs.k8s.io/controller-runtime@v0.20.1/pkg/internal/controller/controller.go:224 +0x85
      created by sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Start.func2 in goroutine 260
      	sigs.k8s.io/controller-runtime@v0.20.1/pkg/internal/controller/controller.go:220 +0x48d
      

      Happens here: there's no chance cd.spec.platform.aws.anything is set for a GCP cluster. Need to do the nil check dance.

      jstuever@redhat.com should be your reviewer (assuming he isn't the one doing the code).

              jstuever@redhat.com Jeremiah Stuever
              efried.openshift Eric Fried
              None
              None
              None
              None
              None
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: