Uploaded image for project: 'External Secrets Operator for Red Hat OpenShift'
  1. External Secrets Operator for Red Hat OpenShift
  2. ESO-289

Fix issues reported by the golangci-lint tool

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • None
    • None
    • 2
    • False
    • Hide

      None

      Show
      None
    • False
    • Not Selected
    • OAPE Sprint 282
    • 1

      In the previous task https://issues.redhat.com/browse/ESO-287, the tool was updated from v1 to v2 and number of new linters were added, which reported below number of issues, which should be addressed as part of this tracker.

      120 issues:
      * contextcheck: 2
      * embeddedstructfieldcheck: 5
      * errname: 2
      * errorlint: 1
      * forcetypeassert: 6
      * goconst: 5
      * gocritic: 10
      * godoclint: 2
      * godot: 3
      * kubeapilinter: 50
      * modernize: 9
      * nestif: 6
      * prealloc: 4
      * staticcheck: 4
      * unparam: 5
      * whitespace: 6
      

      Make use of `make lint-fix` to leverage the tool provided automation for fixing the issues and remaining should be manual task.

      Acceptance Criteria:

      • All the issues are resolved
      • Disabled linters in the golanci-lint config file are enabled and a new tracker is created for the reported issues.

              bhb@redhat.com Bharath B
              bhb@redhat.com Bharath B
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: