Uploaded image for project: 'OpenShift Virtualization'
  1. OpenShift Virtualization
  2. CNV-55151

List only the supported volumeMode for the selected storage class

    • 13
    • False
    • Hide

      None

      Show
      None
    • False
    • CNV v4.19.0.rhel9-121
    • ---
    • ---
    • Moderate
    • None

      Description of problem:

      When creating VM from console, select the option to customize VM creation. Select the disks and edit the disk to select the storage class. The 'AccessMode' and 'VolumeMode' are listed for the selected storage class and those are static values and do not change according to the selected storage class.
      
      We have an issue where selecting the volumemode which is not supported by storage class, then DV creation happens forever (https://issues.redhat.com/browse/CNV-55147).
      
      So to avoid customers ending up in this scenario, the validation should be added in the product. At the same time, it would be very helpful if the volumemode is refreshed according to the selected storage class.
      If this is not possible, then at least an 'info/caution note' to be added to the users to select the volumemode as supported by storage class.

      Version-Release number of selected component (if applicable):

      CNV v4.18

      How reproducible:

      Always

      Steps to Reproduce:

      1.Create VM from template, and select customize VM
      2. Edit the disk, select rootdisk, select the storage class which doesn't support volumeMode 'Block' for example: trident-nfs
      3. Now the volume mode stays with default value as 'Block'
      4. Create VM
      

      Actual results:

      VM creation doesn't complete.

      Expected results:

      1. The volumeMode should get updated to 'Filesystem' only value when the storage profile supports only 'Filesystem'
      2. If the above is not possible, add a important/caution note to users to select the volumeMode as supported by storage class

      Additional info:

       

            [CNV-55151] List only the supported volumeMode for the selected storage class

            cnv-qe jira added a comment -

            A build that contains the fix PR(s) for this bug is available, moving status from MODIFIED to ON_QA.
            The first build that contains https://github.com/kubevirt-ui/kubevirt-plugin/pull/2524 is CNV v4.19.0.rhel9-121.

            cnv-qe jira added a comment - A build that contains the fix PR(s) for this bug is available, moving status from MODIFIED to ON_QA. The first build that contains https://github.com/kubevirt-ui/kubevirt-plugin/pull/2524 is CNV v4.19.0.rhel9-121 .

            CPaaS Service Account mentioned this issue in merge request !2479 of cpaas-midstream / openshift-virtualization / kubevirt-plugin on branch cnv-4.99-rhel-9_upstream_12ebe8ff568dec10de719d36fdf64ecd:

            Updated US source to: b3f53ba Merge pull request #2590 from upalatucci/hide-tree-switch

            GitLab CEE Bot added a comment - CPaaS Service Account mentioned this issue in merge request !2479 of cpaas-midstream / openshift-virtualization / kubevirt-plugin on branch cnv-4.99-rhel-9_ upstream _12ebe8ff568dec10de719d36fdf64ecd : Updated US source to: b3f53ba Merge pull request #2590 from upalatucci/hide-tree-switch

            CPaaS Service Account mentioned this issue in merge request !2478 of cpaas-midstream / openshift-virtualization / kubevirt-plugin on branch cnv-4.19-rhel-9_upstream_12ebe8ff568dec10de719d36fdf64ecd:

            Updated US source to: b3f53ba Merge pull request #2590 from upalatucci/hide-tree-switch

            GitLab CEE Bot added a comment - CPaaS Service Account mentioned this issue in merge request !2478 of cpaas-midstream / openshift-virtualization / kubevirt-plugin on branch cnv-4.19-rhel-9_ upstream _12ebe8ff568dec10de719d36fdf64ecd : Updated US source to: b3f53ba Merge pull request #2590 from upalatucci/hide-tree-switch

            cnv-qe jira added a comment -

            All linked PR(s) of this bug have been merged, moving status from POST to MODIFIED.
            https://github.com/kubevirt-ui/kubevirt-plugin/pull/2524 merged at 2025-04-22 13:20:37

            cnv-qe jira added a comment - All linked PR(s) of this bug have been merged, moving status from POST to MODIFIED. https://github.com/kubevirt-ui/kubevirt-plugin/pull/2524 merged at 2025-04-22 13:20:37

            LGMT, thank you rszwajko@redhat.com The recommended tooltip is just missing a period at the end

            Allison Wolfe added a comment - LGMT, thank you rszwajko@redhat.com The recommended tooltip is just missing a period at the end

            Radoslaw Szwajkowski added a comment - - edited

            wolfeallison yfrimanm 
            Here's the tooltip summary after the updates:

            Radoslaw Szwajkowski added a comment - - edited wolfeallison yfrimanm   Here's the tooltip summary after the updates:

            Oooh I see-- I didn't realize it was dynamic but that makes so much more sense!

             

            • Recommended: "The 2nd most suggested option in StorageProfile" 

            Allison Wolfe added a comment - Oooh I see-- I didn't realize it was dynamic but that makes so much more sense!   Recommended: "The 2nd most suggested option in StorageProfile" 

            For recommended, I changed it from the second most, to not the top in case we have multiple "recommended" options so it isn't confusing they all are second
            The number in the message is dynamic - precisely the message template looks the following:

            Ranks {{priority}} among options recommended in the StorageProfile.

            The idea was to cover all other "recommended" cases with one message - in the previous iteration I had dedicated messages i.e. "The second most recommended ..." , "The third most ..." etc.

            Learn more about StorageProfile.
            Sounds good. I can add it also behind "Access Mode" radio group header.

            Radoslaw Szwajkowski added a comment - For recommended, I changed it from the second most, to not the top in case we have multiple "recommended" options so it isn't confusing they all are second The number in the message is dynamic - precisely the message template looks the following: Ranks {{priority}} among options recommended in the StorageProfile. The idea was to cover all other "recommended" cases with one message - in the previous iteration I had dedicated messages i.e. "The second most recommended ..." , "The third most ..." etc. Learn more about StorageProfile. Sounds good. I can add it also behind "Access Mode" radio group header.

            yfrimanm rszwajko@redhat.com thank you for answering my questions!

            What do you think of these?

            • Highly recommended: The most suggested StorageProfile option
            • Recommended: Not the top StorageProfile option, but still suggested  
            • Not recommended: We suggest using another option

             

            I like what you had for the highly recommended option tooltip. Changed it slightly from "recommended" to "suggested" so we don't repeat the word in the explanation

            For recommended, I changed it from the second most, to not the top in case we have multiple "recommended" options so it isn't confusing they all are second

             

            For the tooltip for volume mode and access mode, I love the idea of putting the documentation! What do you think of "Learn more about StorageProfile." ?

            Allison Wolfe added a comment - yfrimanm rszwajko@redhat.com thank you for answering my questions! What do you think of these? Highly recommended: The most suggested StorageProfile option Recommended: Not the top StorageProfile option, but still suggested   Not recommended: We suggest using another option   I like what you had for the highly recommended option tooltip. Changed it slightly from "recommended" to "suggested" so we don't repeat the word in the explanation For recommended, I changed it from the second most, to not the top in case we have multiple "recommended" options so it isn't confusing they all are second   For the tooltip for volume mode and access mode, I love the idea of putting the documentation! What do you think of "Learn more about StorageProfile." ?

            could we add an equivalent tooltip messages to the Access mode?

            Yes. However the options are configured together (it's a mapping) so we would need to repeat the same message.
            I've added the help text next to the volume because it's first (and we have no header or section).

            Radoslaw Szwajkowski added a comment - could we add an equivalent tooltip messages to the Access mode ? Yes. However the options are configured together (it's a mapping) so we would need to repeat the same message. I've added the help text next to the volume because it's first (and we have no header or section).

              rszwajko@redhat.com Radoslaw Szwajkowski
              sasundar@redhat.com Satheesaran Sundaramoorthi
              Leon Kladnitsky Leon Kladnitsky
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Created:
                Updated: